Towners tsv #8288
Open
Towners tsv #8288
+878
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add townerdat.cpp/hpp for loading towner data from TSV files - Add towners.tsv with towner definitions (position, animation, gossip) - Add quest_dialog.tsv with quest dialog mappings - Supports loading towner properties from data files instead of hardcoded values
- Replace hardcoded towner data with TSV-based loading - Add InitTownerFromData() for default initialization from TSV entries - Update InitTowners() to load data from TSV files - Maintain special initialization for cows and cow farmer - Add TownerBehaviors lookup table for O(1) behavior access - Store animation order data with stable addresses for span usage
- Replace QuestDialogTable direct access with GetTownerQuestDialog() - Replace QuestDialogTable assignments with SetTownerQuestDialog() - Update quests.cpp to use new quest dialog API - Update stores.cpp to use new quest dialog API in StartTalk() and TalkEnter() - Quest dialog data now loaded from quest_dialog.tsv
- Add townerdat.cpp to Source/CMakeLists.txt - Add towner TSV files to CMake/Assets.cmake - Add townerdat_test to CMake/Tests.cmake - Add test fixtures for towner TSV files - Add townerdat_test.cpp for testing towner data loading
yuripourre
force-pushed
the
towners-tsv
branch
from
c66015c to
a084180
Compare
AJenbo
reviewed
Nov 27, 2025
AJenbo
reviewed
Nov 27, 2025
AJenbo
reviewed
Nov 27, 2025
AJenbo
reviewed
Nov 27, 2025
| /** | ||
| * @brief Finds the towner data entry from TSV for a given type. | ||
| */ | ||
| [[maybe_unused]] const TownerDataEntry *FindTownerDataEntry(_talker_id type, Point position = {}) |
Member
There was a problem hiding this comment.
Seems this is a debug only function?
Collaborator
Author
There was a problem hiding this comment.
Yes, it is only called inside DebugTalkToTowner.
I don't know the best way to deal with that.
Collaborator
Author
|
@AJenbo I tried to make this logic more dynamic but I think I went too far. Please don't merge yet. Let me test Hellfire properly first. |
yuripourre
force-pushed
the
towners-tsv
branch
from
4cb0b85 to
aaa46a4
Compare
yuripourre
force-pushed
the
towners-tsv
branch
from
befe238 to
800dfd8
Compare
yuripourre
force-pushed
the
towners-tsv
branch
from
cad3b36 to
54d310e
Compare
Collaborator
Author
|
@AJenbo so far I didn't find any issues. I think it's good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move towners to TSV file.