Skip to content

Conversation

@kphoenix137
Copy link
Collaborator

Makes the Character Panel code a bit less confusing to work with by keeping the label width and the box width in a struct together. Also deduplicates, since many of the boxes on the panel are the same size, along with the label widths used for those sizes.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Source/panels/charpanel.cpp:48

  • The comment on the PanelLabel member 'width' is misleading now that it contains both labelWidth and boxWidth. Consider updating the comment to reflect that it holds dimensions for both the label and its corresponding box.
PanelLabel width;                                              // max label's length - used for line wrapping

Source/panels/charpanel.cpp:138

  • [nitpick] The name 'noTextNarrowLabel' is ambiguous and may confuse developers regarding its intended purpose. Consider renaming it to a more descriptive identifier that clarifies its role in the UI layout.
PanelLabel noTextNarrowLabel = { 0, 45 };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant