Update to Angular 17 and fix issues with Notification navigation in Angular 16+#372
Open
sungkhum wants to merge 7 commits intodiamond-app:mainfrom
Open
Update to Angular 17 and fix issues with Notification navigation in Angular 16+#372sungkhum wants to merge 7 commits intodiamond-app:mainfrom
sungkhum wants to merge 7 commits intodiamond-app:mainfrom
Conversation
…ular/cdk@16, @angular/cli@16, @angular/core@16, @angular/material@16, ngx-toastr@*
…mproperly being called on Notifications in ngOnDestroy() causing the initial route navigation to be cancelled when trying to navigate away from the Notifications view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to Angular 17 as well as fixed a bug because of how query params were being cleared on the Notification route which caused users to be unable to navigate away from Notifications because two routes were being fired simultaneously.