Skip to content

#42 add setDataForLanguage() #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbertin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#42 add setDataForLanguage() #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e7708
#42 add setDataForLanguage()
Jan 21, 2015
932272f
add changelog version
Jan 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ngBabelfish",
"version": "1.7.1",
"version": "1.7.2",
Copy link
Owner

@dhoko dhoko Mar 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run node version.js 1.7.3, the 1.7.2 is already available.

"homepage": "https://github.com/dhoko/ngBabelfish",
"authors": [
"dhoko <aurelien@procheo.fr>"
Expand Down
7 changes: 7 additions & 0 deletions i18n/factory/translator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,13 @@ module.exports = ['$rootScope', '$http', function ($rootScope, $http) {

},

setDataForLanguage: function setDataForLanguage(data, language) {

if(config.lazy) {
i18n.data[language] = data;
Copy link
Owner

@dhoko dhoko Feb 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

Copy link
Contributor Author

@mbertin mbertin Mar 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because i have to add data for a language after init and it doesn't work with the current code. I can't set the language dynamically

Copy link
Owner

@dhoko dhoko Mar 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup but your code doesn't work if we are not using lazy mode. :)

}
},

/**
* Configure this factory
*
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ng-babelfish",
"version": "1.7.1",
"version": "1.7.2",
"description": "Internationalization module for angular.js, it's magic !",
"main": "dist/bundle.js",
"scripts": {
Expand Down