Skip to content

Conversation

fspreiss
Copy link
Member

@fspreiss fspreiss commented Sep 11, 2025

Adapts the password_manager and password_manager_with_metadata examples so that they work again with ICP Ninja, which recently upgraded to DFX 0.29.1, which ships with a new motoko compiler (0.16.1). The necessary changes for this were

  • Declaring the actor as persistent and fixing the compiler issues

The Github workflow sets the DFX_VERSION environment variable, so that only this example uses the new DFX version 0.29.1. This also required to change the bind host from localhost to 127.0.0.1 as otherwise this new DFX version hits the following error:

Error: The replica returned an HTTP Error: Http Error: status 400 Bad Request, content type "text/plain; charset=utf-8", content: error: no_authority
details:
The request is missing the required authority information (e.g. 'Host' header).

The changes were tested in ICP Ninja with the following link:

Password manager:

Password manager with metadata:

@fspreiss fspreiss marked this pull request as ready for review September 11, 2025 21:11
@fspreiss fspreiss requested a review from a team as a code owner September 11, 2025 21:11
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fspreiss fspreiss requested a review from altkdf September 29, 2025 12:46
@fspreiss fspreiss merged commit 7f0abce into main Sep 29, 2025
22 checks passed
@fspreiss fspreiss deleted the franzstefan/CRP-2924-password-managers branch September 29, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants