Skip to content

feat: CRP-2844 CRP-2850 CRP-2853 add Motoko basic IBE backend and enable its use in ICP Ninja #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 26, 2025
Merged

feat: CRP-2844 CRP-2850 CRP-2853 add Motoko basic IBE backend and enable its use in ICP Ninja #158

merged 20 commits into from
Jun 26, 2025

Conversation

altkdf
Copy link
Contributor

@altkdf altkdf commented Jun 25, 2025 •
edited
Loading

Also:

  • Adds helper functions for the management canister VetKD API and signing with BLS.
  • Removes the frontend declarations from the repo, since they are generated upon deployment.

@altkdf altkdf changed the title feat: add Motoko basic IBE backend and enable its use in ICP Ninja feat: CRP-2844 CRP-2850 add Motoko basic IBE backend and enable its use in ICP Ninja Jun 25, 2025
@altkdf altkdf mentioned this pull request Jun 25, 2025
Merged
@altkdf
Copy link
Contributor Author

altkdf commented Jun 25, 2025 •
edited
Loading

ICP Ninja doesn't yet support init arguments for canisters, also not the default ones. This should be added soon (days?). Once that works, the canister should be deployable from this link for motoko and from this link for rust.

Once that works, we can add icons for deployment to the README.

@altkdf altkdf marked this pull request as ready for review June 25, 2025 18:26
@altkdf altkdf requested a review from a team as a code owner June 25, 2025 18:26
randombit
randombit approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor questions/suggestions, otherwise lgtm

@altkdf altkdf changed the title feat: CRP-2844 CRP-2850 add Motoko basic IBE backend and enable its use in ICP Ninja feat: CRP-2824 CRP-2844 CRP-2850 add Motoko basic IBE backend and enable its use in ICP Ninja Jun 26, 2025
@altkdf altkdf changed the title feat: CRP-2824 CRP-2844 CRP-2850 add Motoko basic IBE backend and enable its use in ICP Ninja feat: CRP-2853 CRP-2844 CRP-2850 add Motoko basic IBE backend and enable its use in ICP Ninja Jun 26, 2025
@altkdf altkdf changed the title feat: CRP-2853 CRP-2844 CRP-2850 add Motoko basic IBE backend and enable its use in ICP Ninja feat: CRP-2844 CRP-2850 CRP-2853 add Motoko basic IBE backend and enable its use in ICP Ninja Jun 26, 2025
altkdf
altkdf commented Jun 26, 2025
View reviewed changes
@altkdf altkdf merged commit 6ab878c into main Jun 26, 2025
25 checks passed
@altkdf altkdf deleted the alex/basic-ibe-motoko-and-ninja branch June 26, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randombit randombit randombit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altkdf @randombit