fix: misleading asset canister api version error#4506
Merged
viviveevee merged 3 commits intomasterfrom Mar 24, 2026
Merged
Conversation
viviveevee
commented
Mar 24, 2026
| ## Dependencies | ||
|
|
||
| ## Fixes | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Doesn't match the changelog format we've used so far
…cli-syncing-to-asset-canister
lwshang
approved these changes
Mar 24, 2026
viviveevee
deleted the
SDK-2634-check-dependency-issues-with-icp-cli-syncing-to-asset-canister
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of asset sync we make sure the asset canister supports the required API version. If an asset canister is missing the function to query the API version it is on version
0. The check for the API version previously did not attempt to discriminate between network issues and the function not existing, so a slight hiccup in network connectivity could be misreported as an outdated asset canister.Fixes SDK-2634
How Has This Been Tested?
Manually tested that version incompatibility still reports the correct error. I don't know how to test that agent errors bubble up properly
Checklist: