chore: upgrade Rust agent crates to 0.46 and bump ic-asset to 0.28.0#4492
Merged
chore: upgrade Rust agent crates to 0.46 and bump ic-asset to 0.28.0#4492
Conversation
- Add `log_memory_limit: None` to `CanisterSettings` struct literals in migrate.rs, cmc.rs, and ic_attributes/mod.rs - Replace removed `with_optional_*` builder methods in create_canister.rs with conditional `with_*` calls - Add `MgmtMethod::CanisterMetadata` to the match arm in call.rs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aws-lc-sys (pulled in via ic-agent 0.46 → reqwest 0.13 → rustls 0.23 → aws-lc-rs → aws-lc-sys) uses the OpenSSL license. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamspofford-dfinity
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the Rust agent crates (
ic-agent,ic-utils,ic-identity-hsm,ic-management-canister-types) from 0.45/0.5 to 0.46/0.7.1, bumpsic-assetandicx-assetto version 0.28.0, and updates the pocket-ic server/client to IC rev142182f2.Why this is needed:
icp-clidepends on bothic-assetand the Rust agent crates. To upgrade the Rust agent crates inicp-cli, it needs anic-assetrelease that is built against the same agent version. This PR produces that release (ic-asset 0.28.0) soicp-clican consume it.Changes
ic-agent,ic-utils,ic-identity-hsmto0.46.0andic-management-canister-typesto0.7.1ic-assetandicx-assetto0.28.0log_memory_limit: NonetoCanisterSettingsstruct literals (new field inic-management-canister-types 0.7.1)with_optional_*builder methods increate_canister.rswith conditionalwith_*callsMgmtMethod::CanisterMetadatato the exhaustive match incanister/call.rs(new variant inic-utils 0.46.0)OpenSSLlicense indeny.toml:ic-agent 0.46upgradedreqwestto0.13, which brought inrustls 0.23. That version ofrustlsusesaws-lc-rsas its default crypto backend (instead ofring), which requiresaws-lc-sys— a crate licensed underISC AND (Apache-2.0 OR ISC) AND OpenSSL.142182f2:ic-management-canister-types 0.7.1addedlog_memory_store_sizetoMemoryMetricsandlog_memory_limittoDefiniteCanisterSettingsin thecanister_statusresponse. The previous pocket-ic rev (b0a37d) predates these fields, causing e2e test failures due to Candid decode errors on required-but-absent fields. The new rev includes both fields.Test plan
cargo checkpassescargo deny check licensespassescanister_statuspass with the updated pocket-ic