fix: prevent duplicate GitHub releases in publish workflow#4489
Merged
fix: prevent duplicate GitHub releases in publish workflow#4489
Conversation
The publish job used a matrix strategy that ran 4 parallel jobs (one per architecture), each independently calling upload-release-action. This caused a race condition where multiple releases were created for the same tag. Fix by removing the matrix, downloading all artifacts in a single job with merge-multiple, and merging the publish-assets job into the publish job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
raymondk
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publishjob used a matrix strategy that ran 4 parallel jobs (one per architecture), each independently callingsvenstaro/upload-release-action. This caused a race condition where multiple releases were created for the same tag (we saw 3 duplicate0.31.0releases).publish, usingdownload-artifactwithpattern+merge-multiple: trueto download all artifacts in a single job.publish-assetsinto thepublishjob so only one job creates the release.Test plan
The test release https://github.com/dfinity/sdk/releases/tag/0.0.0-test.0 contains all 20 artifacts as expected.