chore(ci): bump Rust toolchain to 1.88.0 and pin external dependencies#622
Merged
chore(ci): bump Rust toolchain to 1.88.0 and pin external dependencies#622
Conversation
Rust 1.88.0 stabilizes let chains and enables the
`uninlined_format_args` clippy lint. Fix all instances of
`format!("{}", x)` -> `format!("{x}")` across the workspace
to keep CI green under `-D clippy::all`.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The integration tests and e2e tests were failing because external dependencies were fetched from unpinned sources (latest/master): - assetstorage.wasm downloaded from dfinity/sdk master now imports env_var_count from ic0, which PocketIC server 9.0.3 does not support - Internet Identity latest release changed its UI, removing the #registerButton element expected by e2e tests Pin both to known-working versions: - assetstorage.wasm: pin to SDK commit d65717bd (matching the ic-certified-assets git dependency already in Cargo.lock) - Internet Identity: pin to release-2025-08-29 (last release before the final successful CI run) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aterga
changed the title
aterga
changed the title
sea-snake
approved these changes
Apr 1, 2026
mraszyk
approved these changes
Apr 1, 2026
sea-snake
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-toolchain.tomluninlined_format_argsclippy warnings introduced by 1.88's stricter-D clippy::allenforcement:format!("{}", x)→format!("{x}")across the workspaceassetstorage.wasm.gzdownload to a specific SDK commit (d65717bd) to prevent CI breakage from the unpinnedmasterbranch importingenv_var_count(unsupported by PocketIC server)dfx.jsontorelease-2025-08-29to prevent e2e test breakage from UI changes in newer releasesWhy
Rust 1.88.0 stabilizes let chains and tightens the
uninlined_format_argslint. This is a prerequisite for upgradingpocket-icto 13.0.0 (which requires 1.88) in a follow-up PR.The external dependency pinning fixes flaky CI caused by fetching from unpinned
latest/mastersources.Test plan
validate-rustpasses (cargo clippy -D clippy::all+cargo fmt --check)integration-testspasse2e-testspass🤖 Generated with Claude Code