chore: track .icp/data/mappings via .gitkeep and clarify .gitignore#20
Merged
chore: track .icp/data/mappings via .gitkeep and clarify .gitignore#20
Conversation
Add .icp/data/mappings/.gitkeep to all templates so the directory structure is visible from the start, signaling that .icp/data/ is meant to be committed. Update .gitignore in all templates with clarifying comments that only .icp/cache/ should be ignored, not .icp/data/ which stores mainnet canister ID mappings. Closes #19
The mappings subdirectory is created automatically by icp-cli. Tracking .icp/data/ is sufficient to signal the directory should be committed.
lwshang
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .icp/data/mappings/.gitkeep to all templates so the directory structure is visible from the start, signaling that .icp/data/ is meant to be committed.
Update .gitignore in all templates with clarifying comments that only .icp/cache/ should be ignored, not .icp/data/ which stores mainnet canister ID mappings.
Closes #19