Merged
Conversation
raymondk
reviewed
Jan 20, 2026
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Update latest tag |
Collaborator
There was a problem hiding this comment.
This is automatically pushing a $RECIPE-latest tag
When the tag is pushed doesn't that throw off the pipeline for latest because it is going to compare to whatever the highest version tag is (which will likely be the same) and not generate the proper release notes?
Member
Author
There was a problem hiding this comment.
I am not entirely sure what your concern is, so let me address both possibilities:
-
if you're worried about the
-latestrelease having empty/wrong release notes:- you're right - the original code would compare
rust-v5.0.0..rust-latestwhich are the same commit, resulting in empty release notes. - I fixed this now by finding the versioned tag on the same commit (
rust-v5.0.0), then comparing against its predecessor (rust-v4.0.0..rust-v5.0.0). now both releases should get the same correct release notes.
- you're right - the original code would compare
-
if you're worried about
-latesttags interfering with versioned releases:- this should already be safe - the previous tag search uses the pattern
${RECIPE}-v*, which only matches versioned tags likerust-v5.0.0and never matchesrust-latest.
- this should already be safe - the previous tag search uses the pattern
these are the scenarios that should be covered now:
| Scenario | PREV_TAG | COMPARE_TAG | Result |
|---|---|---|---|
1. Push rust-v4.0.0 |
rust-v3.0.0 | rust-v4.0.0 | Changelog ✓ |
2. rust-latest triggered (same commit as rust-v4.0.0) |
rust-v3.0.0 | rust-v4.0.0 | Changelog ✓ |
3. Push newrecipe-v1.0.0 (first ever version) |
(empty) | newrecipe-v1.0.0 | Initial release ✓ |
4. newrecipe-latest triggered (same commit as v1.0.0) |
(empty) | newrecipe-v1.0.0 | Initial release ✓ |
5. Push newrecipe-latest without versioned tag |
- | - | Fails ✓ |
let me know if you had a different concern in mind.
raymondk
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we have a problem with displaying the changes correctly for each recipe on releases and vibed a bit with Claude to fix it.
should work for all recipes.