perf: [DSM-144] Misc certification optimizations#10510
Conversation
* Use precomputed empty leaf hash instead of computing it from scratch every time. * Pass the key to `MapTransformFork::mk_tree` by reference, don't clone it (especially since it's only used in a couple of cases). * Simplidy CanisterFork.
|
This speeds up sequential |
|
✅ No security or compliance issues detected. Reviewed everything up to a6f274f. Security Overview
Detected Code Changes| Change Type | Relevant files ... (code changes summary truncated to fit VCS comment limits.) |
| } | ||
|
|
||
| const CERTIFIED_DATA_LABEL: &[u8] = b"certified_data"; | ||
| const CONTROLLER_LABEL: &[u8] = b"controller"; |
There was a problem hiding this comment.
Is this gone in all certification versions?
There was a problem hiding this comment.
Yes, only the labels in CANISTER_LABELS and CANISTER_NO_MODULE_LABELS are (and were, before this change) populated.
This was left behind from some old certification version, likely because the match statements below still referenced it, so the compiler did not report it as unused.
MapTransformFork::mk_treeby reference, don't clone it (especially since it's only used in a couple of cases).CanisterFork.