feat: CON-1467 CON-1705 Set registry version of CanisterHttpContexts#10505
Draft
eichhorl wants to merge 2 commits into
Draft
feat: CON-1467 CON-1705 Set registry version of CanisterHttpContexts#10505eichhorl wants to merge 2 commits into
CanisterHttpContexts#10505eichhorl wants to merge 2 commits into
Conversation
eichhorl
changed the title
CanisterHttpContextsCanisterHttpContexts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10484 introduced a
RegistryVersionfield toCanisterHttpContexts. For compatibility reasons, the field was introduced to the proto definition but always set to 0 in all production cases.With this PR, we start setting the field to the registry version at which new
CanisterHttpContexts are created. In the future this field will be used as the single source of truth for the registry version throughout the lifetime of an HTTP outcall.For compatibility reasons, a subnet running the version of this PR should not be directly downgraded to a version earlier than #10484 (corresponding replica version proposed here).