chore: align hello_world frontend vite.config with icp-cli template#1426
Merged
Conversation
Restructure the Motoko hello_world frontend dev server config to match the icp-cli React template: derive both the root key and proxy target from a single `icp network status --json` call, support ICP_ENVIRONMENT, and fail clearly when the backend canister isn't deployed. Drops the dfx fallback (and the now-unused loadEnv/define/optimizeDeps blocks); actor.js now resolves the canister ID from the ic_env cookie only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lwshang
approved these changes
Jun 25, 2026
Apply the same dev server config changes as the Motoko hello_world frontend: derive root key and proxy target from a single `icp network status --json` call, support ICP_ENVIRONMENT, and fail clearly when the backend canister isn't deployed. Drops the dfx fallback (and the now-unused loadEnv/define/optimizeDeps blocks); actor.js resolves the canister ID from the ic_env cookie only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make the example match the cli templates.