Skip to content

fix(rust/receiving-icp): rename staging→ic, drop production environment#1425

Merged
marc0olo merged 1 commit into
masterfrom
chore/fix-receiving-icp-environment-config
Jun 19, 2026
Merged

fix(rust/receiving-icp): rename staging→ic, drop production environment#1425
marc0olo merged 1 commit into
masterfrom
chore/fix-receiving-icp-environment-config

Conversation

@marc0olo

Copy link
Copy Markdown
Member

Summary

Follow-up to #1394 — aligns the environment configuration with the pattern established in rust/basic_ethereum.

Changed:

  • stagingic (standard icp-cli environment name for ICP mainnet)
  • production environment removed; a comment in icp.yaml explains how to adapt ICP_LEDGER_CANISTER_ID to the real ICP ledger for production use
  • README updated: table and deploy command reflect ic instead of staging/production; production guidance points to the icp.yaml comment

🤖 Generated with Claude Code

Aligns with the icp-cli convention used in basic_ethereum:
- staging → ic (standard environment name for ICP mainnet deployments)
- production removed; a comment in icp.yaml explains how to adapt
  ICP_LEDGER_CANISTER_ID for the real ICP ledger

README updated: table now shows ic instead of staging/production, deploy
command is icp deploy -e ic, production guidance points to icp.yaml comment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marc0olo marc0olo marked this pull request as ready for review June 19, 2026 09:02
@marc0olo marc0olo requested a review from a team as a code owner June 19, 2026 09:02
@marc0olo marc0olo merged commit dc02375 into master Jun 19, 2026
6 checks passed
@marc0olo marc0olo deleted the chore/fix-receiving-icp-environment-config branch June 19, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants