chore: migrate rust/simd to icp-cli#1404
Open
marc0olo wants to merge 4 commits into
Open
Conversation
91d61d9 to
7a0410a
Compare
- Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0 - Move mat_mat_mul/ source into backend/ subdirectory - Rename package to backend, update ic-cdk to 0.20, replace ic_cdk_macros with ic_cdk - Update Makefile with icp canister call --query tests for all 7 methods - Update README with icp-cli deploy instructions, preserve SIMD performance insights - Add .github/workflows/simd.yml CI job (icp-dev-env-rust:1.0.0) - Delete dfx.json, BUILD.md, .devcontainer/, mat_mat_mul/ - Keep .cargo/config.toml with wasm32 SIMD target-feature comments Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7a0410a to
01971df
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
schneiderstefan
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
rust/simdfrom dfx to icp-cli.Removed:
dfx.json,BUILD.md,.devcontainer/, oldMakefileChanged:
mat_mat_mul/intobackend/; package renamed tobackendic-cdkupdated to 0.20;ic-cdk-macrosreplaced with macros re-exported fromic_cdk.cargo/config.tomlpreserved with SIMD target-feature comments (critical for per-function#[target_feature(enable = "simd128")]approach)Added:
icp.yamlwith@dfinity/rust@v3.3.0recipetest.shwith 7 tests covering all public query methods (non-zero instruction count assertions).github/workflows/simd.ymlusingicp-dev-env-rust:1.0.1Test plan
icp network start -d && icp deploy && bash test.shpassesrust-simdpasses🤖 Generated with Claude Code