Skip to content

chore: migrate rust/simd to icp-cli#1404

Open
marc0olo wants to merge 4 commits into
masterfrom
chore/migrate-rust-simd-to-icp-cli
Open

chore: migrate rust/simd to icp-cli#1404
marc0olo wants to merge 4 commits into
masterfrom
chore/migrate-rust-simd-to-icp-cli

Conversation

@marc0olo

@marc0olo marc0olo commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

Migrates rust/simd from dfx to icp-cli.

Removed: dfx.json, BUILD.md, .devcontainer/, old Makefile

Changed:

  • Source moved from mat_mat_mul/ into backend/; package renamed to backend
  • ic-cdk updated to 0.20; ic-cdk-macros replaced with macros re-exported from ic_cdk
  • .cargo/config.toml preserved with SIMD target-feature comments (critical for per-function #[target_feature(enable = "simd128")] approach)

Added:

  • icp.yaml with @dfinity/rust@v3.3.0 recipe
  • test.sh with 7 tests covering all public query methods (non-zero instruction count assertions)
  • CI workflow .github/workflows/simd.yml using icp-dev-env-rust:1.0.1

Test plan

  • icp network start -d && icp deploy && bash test.sh passes
  • CI job rust-simd passes

🤖 Generated with Claude Code

@marc0olo marc0olo force-pushed the chore/migrate-rust-simd-to-icp-cli branch from 91d61d9 to 7a0410a Compare June 17, 2026 17:01
marc0olo and others added 2 commits June 19, 2026 08:32
- Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0
- Move mat_mat_mul/ source into backend/ subdirectory
- Rename package to backend, update ic-cdk to 0.20, replace ic_cdk_macros with ic_cdk
- Update Makefile with icp canister call --query tests for all 7 methods
- Update README with icp-cli deploy instructions, preserve SIMD performance insights
- Add .github/workflows/simd.yml CI job (icp-dev-env-rust:1.0.0)
- Delete dfx.json, BUILD.md, .devcontainer/, mat_mat_mul/
- Keep .cargo/config.toml with wasm32 SIMD target-feature comments

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marc0olo marc0olo force-pushed the chore/migrate-rust-simd-to-icp-cli branch from 7a0410a to 01971df Compare June 19, 2026 06:34
marc0olo and others added 2 commits June 19, 2026 16:59
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marc0olo marc0olo marked this pull request as ready for review June 19, 2026 15:08
@marc0olo marc0olo requested review from a team as code owners June 19, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants