-
Notifications
You must be signed in to change notification settings - Fork 48
#1547: Added new documentation for installing IDEasy on Ubuntu in WSL #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
#1547: Added new documentation for installing IDEasy on Ubuntu in WSL #1650
Conversation
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkosim Thanks for your PR.
Great that you managed to get everything installed properly and writing this documentation 👍
I left some small comments for improvement.
After this is resolved, we can merge.
…on clearer in some steps.
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkosim thanks for your quick rework. 👍
Can you recheck the image files you added. IMHO they are all broken:
Example:
https://github.com/hkosim/IDEasy/blob/fa1c362d033c85d88c91ff0305d28a4135f1f261/documentation/IDEasy-testing-linux-on-windows.adoc
When I downloaded one of the images as raw file from GitHub and opened it in paint it showed only a white rectangle.
Pull Request Test Coverage Report for Build 20336062527Details
💛 - Coveralls |
devySingh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully able to install IDEasy on Ubuntu.
This PR closes #1547
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)