Skip to content

Tweaks #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

Tweaks #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eec4e8
Ignore React not in scope
olafveerman Jul 21, 2025
0008e9f
Don't print NODE version in checks
olafveerman Jul 21, 2025
9c0decf
Remove unused baseName
olafveerman Jul 21, 2025
d97b868
Comment unused variables
olafveerman Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Use Node.js ${{ env.NODE }}
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -60,7 +60,7 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Use Node.js ${{ env.NODE }}
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v4

- name: Use Node.js ${{ env.NODE }}
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
Expand All @@ -107,4 +107,4 @@ jobs:
run: pnpm install

- name: Test
run: pnpm test
run: pnpm test
17 changes: 9 additions & 8 deletions app/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ import { createRoot } from 'react-dom/client';

import system from './styles/theme';

// If using a router add the public url to the base path.
const publicUrl = import.meta.env.VITE_BASE_URL || '';
// The ds.io prefix is used just to get the base path when no public url is set.
const baseName = new URL(
publicUrl.startsWith('http')
? publicUrl
: `https://ds.io/${publicUrl.replace(/^\//, '')}`
).pathname;
// // If using a router add the public url to the base path.
// const publicUrl = import.meta.env.VITE_BASE_URL || '';

// // The ds.io prefix is used just to get the base path when no public url is set.
// const baseName = new URL(
// publicUrl.startsWith('http')
// ? publicUrl
// : `https://ds.io/${publicUrl.replace(/^\//, '')}`
// ).pathname;

// Root component.
function Root() {
Expand Down
1 change: 1 addition & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export default [
'prefer-promise-reject-errors': 0,
// 'import/order': 2,
'react/button-has-type': 2,
'react/react-in-jsx-scope': 0,
'react/jsx-closing-bracket-location': 2,
'react/jsx-closing-tag-location': 2,
'react/jsx-curly-spacing': 2,
Expand Down