Add keyword filter to !channels command#23
Merged
Conversation
!channels [keyword] now accepts an optional name filter so users with large channel lists can narrow results without paging through everything. Covers TVheadend and IPTV channels, returns a helpful message when no channels match, and leaves existing pagination untouched.
Owner
|
Thanks for the Pull Request! I like the changes but the unit test are failing, see here and below: If you fix the tests, I'll approve the PR and merge the branch. |
The _apply_filter helper lowercased ch["name"] but not the query itself, so uppercase queries like "ZORBAX" never matched.
Owner
|
The unit tests passed in CI - the workflow only failed because of repository permissions (guess I should skip posting code coverage as a comment for forked PRs...) Thanks for the PR. I'll approve and merge it. |
dev-topsoil
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[keyword]argument to!channelsso users can filter the channel list by name instead of paging through hundreds of resultsTest plan
!channelswith no argument still lists all channels as before!channels bbc(or any keyword) returns only channels whose name contains the keyword!channels BBCand!channels bbcreturn the same results)no channels found matching **keyword**