[WIP] Add method for differentiable 1D histogram#488
Draft
RemiLehe wants to merge 4 commits intodesy-ml:masterfrom
Draft
[WIP] Add method for differentiable 1D histogram#488RemiLehe wants to merge 4 commits intodesy-ml:masterfrom
RemiLehe wants to merge 4 commits intodesy-ml:masterfrom
Conversation
RemiLehe
commented
Jul 8, 2025
|
|
||
| return xp_coords | ||
|
|
||
| def get_1d_histogram( |
Collaborator
Author
There was a problem hiding this comment.
This can be used in plot_1d_distribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method to compute 1D histograms for
ParticleBeamTODO:
- should it be a method of
ParticleBeamonly? => yes, but open an issue to implement for both beams- what normalization to use by default? => Copy interface of
numpy.historgram- should we reuse this function in
plot_1d_distribution(with `method='histogram') => yes- check vectorization
- check that it runs on GPU
Here is a quick code snippet on how to use/test this on GPU: