Improved whisper menu #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11k
requested changes
Sep 6, 2023
Contributor
11k
left a comment
11k
left a comment
There was a problem hiding this comment.
I'd like to finally take a look at this. 😅 Would you mind merging in master and fixing any merge conflicts?
Contributor
Author
|
For some reason the prettier commit didn't merge when I merged the master branch in. |
11k
requested changes
Apr 17, 2024
Contributor
11k
left a comment
11k
left a comment
There was a problem hiding this comment.
Would you mind fixing the merge conflicts, and humanizing the date next to each conversation (e.g., "a month ago")? You can give the date a title so that it displays a local time in a localized format on hover.
11k
requested changes
May 29, 2024
Rework CSS to (loosely) follow BEM guidelines for better readability and to reduce nesting. Simplify CSS by removing unneeded rules and using logical margin and padding properties. Simplify conversation markup by relying on flexbox to correctly position right-aligned elements. Convert online/offline indicator from a pseudo-element to a standard element because the latter is more appropriate. Render the timestamp of conversations as a `time` element because it's semantically correct. Fix layout issue that occurs between username, unread, and time elements when chat font scaling is increased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show all your whispers and indicate if the user is online