Skip to content

check for txn in interim state #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lazynina wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

check for txn in interim state #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion routes/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ func (fes *APIServer) GetTxn(ww http.ResponseWriter, req *http.Request) {
txnStatus = TxnStatusInMempool
}
txnInMempool := fes.backendServer.GetMempool().IsTransactionInPool(txnHash)
//
if txnStatus == TxnStatusInMempool && txnInMempool {
if err := json.NewEncoder(ww).Encode(&GetTxnResponse{TxnFound: true}); err != nil {
_AddBadRequestError(ww, fmt.Sprintf("GetTxn: Problem encoding response as JSON: %v", err))
return
}
}
startTime := time.Now()
// We have to wait until txindex has reached the uncommitted tip height, not the
// committed tip height. Otherwise we'll be missing ~2 blocks in limbo.
Expand All @@ -94,6 +101,14 @@ func (fes *APIServer) GetTxn(ww http.ResponseWriter, req *http.Request) {
_AddBadRequestError(ww, fmt.Sprintf("GetTxn: Timed out waiting for txindex to sync."))
return
}
if lib.DbCheckTxnExistence(fes.TXIndex.TXIndexChain.DB(), nil, txnHash) {
// If the txn is found in txindex, we can return early.
if err := json.NewEncoder(ww).Encode(&GetTxnResponse{TxnFound: true}); err != nil {
_AddBadRequestError(ww, fmt.Sprintf("GetTxn: Problem encoding response as JSON: %v", err))
return
}
return
}
time.Sleep(10 * time.Millisecond)
}
txnInTxindex := lib.DbCheckTxnExistence(fes.TXIndex.TXIndexChain.DB(), nil, txnHash)
Expand All @@ -117,7 +132,7 @@ func (fes *APIServer) GetTxn(ww http.ResponseWriter, req *http.Request) {
}

if err := json.NewEncoder(ww).Encode(res); err != nil {
_AddBadRequestError(ww, fmt.Sprintf("GetSinglePost: Problem encoding response as JSON: %v", err))
_AddBadRequestError(ww, fmt.Sprintf("GetTxn: Problem encoding response as JSON: %v", err))
return
}
}
Expand Down