Skip to content

feat: add zero concentration queueing option for crafting recipes#1037

Open
andreacasarin wants to merge 14 commits intoderfloh205:mainfrom
andreacasarin:main
Open

feat: add zero concentration queueing option for crafting recipes#1037
andreacasarin wants to merge 14 commits intoderfloh205:mainfrom
andreacasarin:main

Conversation

@andreacasarin
Copy link

Summary

  • Adds a new Zero Concentration Queueing option to Queue Favorites settings.
  • When Smart Concentration Queueing is enabled, this option also queues favorite recipe result types that require zero concentration only if profitable.
  • Keeps existing smart concentration behavior intact for concentration-using crafts.
  • Clarifies current baseline behavior: without smart concentration queueing, favorites queueing does not filter by profitability and queues all result types.

Description

What changed

  • Added a new checkbox in Queue Favorites options:
    • Zero Concentration Queueing
  • Extended smart favorites queueing flow so that, when enabled, it additionally queues zero-concentration favorites with positive profit.
  • Added corresponding constants/options/localization entries for the new toggle.

Behavior details

  • Smart Concentration Queueing = OFF:
    • Existing behavior remains unchanged.
    • Favorites queueing queues all result types and does not apply profitability filtering.
  • Smart Concentration Queueing = ON and Zero Concentration Queueing = OFF:
    • Existing smart behavior remains unchanged (focus on concentration-based selection).
  • Smart Concentration Queueing = ON and Zero Concentration Queueing = ON:
    • Existing smart concentration selection still runs.
    • Additionally, zero-concentration favorites are queued only when profitable.

Notes

  • The new feature is intentionally scoped to smart concentration mode only.
  • No changes to release/dependency behavior were required for this feature itself.

* feat: add smart zero concentration queueing option for crafting recipes
@github-project-automation github-project-automation bot moved this to Backlog in CraftSim Mar 13, 2026
@derfloh205 derfloh205 moved this from Backlog to In progress in CraftSim Mar 14, 2026
Locals/enUS.lua Outdated
[CraftSim.CONST.TEXT.CRAFT_QUEUE_ORDER_MINIMUM_QUALITY] = "\nMinimum Quality: ",
[CraftSim.CONST.TEXT.CRAFT_QUEUE_ORDER_REWARDS] = "\nRewards:",
[CraftSim.CONST.TEXT.CRAFT_QUEUE_RESTOCK_FAVORITES_OPTIONS_AUTO_SHOPPING_LIST] = "If enabled, CraftSim will automatically create a shopping list after scanning.",
[CraftSim.CONST.TEXT.CRAFT_QUEUE_ORDER_CUSTOMER] = "\n\nOrder Customer: ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong with line endings here as no changes were made - can you doublecheck?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, sorry about that.

My editor is prone to auto formatting stuff: I fixed it there and also in another place, should be good now.

@avilene
Copy link
Collaborator

avilene commented Mar 16, 2026

@andreacasarin could you make it so its just your 0 concentration change included? No config or anything - it will work and having 0s show up is a good thing when concentration is enabled.

@andreacasarin
Copy link
Author

andreacasarin commented Mar 16, 2026

@andreacasarin could you make it so its just your 0 concentration change included? No config or anything - it will work and having 0s show up is a good thing when concentration is enabled.

Sure, done @avilene.

@derfloh205
Copy link
Owner

I am a bit confused by this PR.
Why was the option removed?

@andreacasarin
Copy link
Author

Wasn't what @avilene asked me for? Did I misunderstood something @derfloh205 ?

@avilene
Copy link
Collaborator

avilene commented Mar 18, 2026

Hey @andreacasarin it seems we had a mixup, we'd like this:

  • Checkbox "Enable Concentration" which is on by default - does not add 0 conc crafts, current behavior
  • when its off, allow favorite queues without concentration (which would also show the 0 concentration crafts)

Copy link
Owner

@derfloh205 derfloh205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry about the mixup but we now discussed what would be nice to have. Ill set this to changes requested again

@andreacasarin
Copy link
Author

I see, I can do that, but that unfortunately wouldn't work for me.

I'll explain: When I go to the profession table I would like to know which of my favorites recipes are craftable. Meaning I have enough concentration and also are profitable. That includes the smart concentration crafting that's already there plus the recipe that requires zero concentration. That's what my change aimed to do.

In addition the smart concentration check is supposed to queue all the recipes that are favorite and affordable on a concentration basis. That means that, in my opinion, the ones that require zero concentration should be included.

Doing it like you suggest would mean that I will click the queue favorite and have all the favorites recipies queued no matter if I have enough concentration or they are actually profitable, defeating the all purpose.

Please let me know what you think about that and also if I'm using the add on somewhat incorrectly.

Screenshot 2026-03-18 at 10 58 35

Screenshot 2026-03-18 at 10 58 57

@derfloh205
Copy link
Owner

@andreacasarin @avilene

Hm so with one click you want to queue all recipes with the concentration based optimizations like above
but then you also want to include recipes that are profitable without using concentration?
But based on what rules, as a recipe can be profitable with and without concentration.
And those without you would want to mass craft and with concentration you would want to only craft so much based on your concentration.

I kinda get what you want.
Though to have it consistent with other auto queueing optimization features. Id rather have a toggle between "use concentration, check what is profitable based on it" and "dont use concentration and queue based on restock rules"

Actually.. I think this "conflict of design opinions" screams for us to start the implementation on "craft lists".
One Idea I had to customize different lists of recipes with different optimization rules. I think that would also kind of solve that

@andreacasarin
Copy link
Author

andreacasarin commented Mar 20, 2026

I see the point now @derfloh205. I didn't think about the fact that a recipe could be profitable with or without concentration.

The thing is that I actually can't queue, even with multiple clicks, the recipes that requires zero concentration and are profitable.

What I usually do is:

  • explore all the recipes that are interesting via the scan profession window
  • set as favorite the ones that I feel like they should sell
  • open the craft window on a daily basis, after scanning the auction house
  • click the queue favorites and expect to have a list of profitable stuff to craft from my favorites

Maybe there is a better way to approach that?

Taking into consideration that the smart queuing is about optimizing concentrations usage per profit and given my current workflow, however, what I think would be nice is:

  • recipes that are already at the max level without concentration: queue them if profitable since those would not require concentration in any circumstances
  • recipes that could require concentration: queue them with or without concentration optimizing for expected profit

In my opinion, I would also apply the quantity offset only to the zero concentration recipes since that's the only case in which I can really decide how many recipe I want to craft, the others are already limited by the concentration that I have.

One more thing is that I find a bit confusing that without smart concentration enabled the system will also queue non-profitable recipes, while with smart concentration it only queues the profitable ones. But that's might be a skill issue on my side. 😅

The craft list idea is really interesting! How would that intersect with the crafting window and the scan profession one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants