feat: add zero concentration queueing option for crafting recipes#1037
feat: add zero concentration queueing option for crafting recipes#1037andreacasarin wants to merge 14 commits intoderfloh205:mainfrom
Conversation
* feat: add smart zero concentration queueing option for crafting recipes
Locals/enUS.lua
Outdated
| [CraftSim.CONST.TEXT.CRAFT_QUEUE_ORDER_MINIMUM_QUALITY] = "\nMinimum Quality: ", | ||
| [CraftSim.CONST.TEXT.CRAFT_QUEUE_ORDER_REWARDS] = "\nRewards:", | ||
| [CraftSim.CONST.TEXT.CRAFT_QUEUE_RESTOCK_FAVORITES_OPTIONS_AUTO_SHOPPING_LIST] = "If enabled, CraftSim will automatically create a shopping list after scanning.", | ||
| [CraftSim.CONST.TEXT.CRAFT_QUEUE_ORDER_CUSTOMER] = "\n\nOrder Customer: ", |
There was a problem hiding this comment.
I think something went wrong with line endings here as no changes were made - can you doublecheck?
There was a problem hiding this comment.
Oh yeah, sorry about that.
My editor is prone to auto formatting stuff: I fixed it there and also in another place, should be good now.
|
@andreacasarin could you make it so its just your 0 concentration change included? No config or anything - it will work and having 0s show up is a good thing when concentration is enabled. |
Sure, done @avilene. |
|
I am a bit confused by this PR. |
|
Wasn't what @avilene asked me for? Did I misunderstood something @derfloh205 ? |
|
Hey @andreacasarin it seems we had a mixup, we'd like this:
|
derfloh205
left a comment
There was a problem hiding this comment.
Sry about the mixup but we now discussed what would be nice to have. Ill set this to changes requested again
|
I see, I can do that, but that unfortunately wouldn't work for me. I'll explain: When I go to the profession table I would like to know which of my favorites recipes are craftable. Meaning I have enough concentration and also are profitable. That includes the smart concentration crafting that's already there plus the recipe that requires zero concentration. That's what my change aimed to do. In addition the smart concentration check is supposed to queue all the recipes that are favorite and affordable on a concentration basis. That means that, in my opinion, the ones that require zero concentration should be included. Doing it like you suggest would mean that I will click the queue favorite and have all the favorites recipies queued no matter if I have enough concentration or they are actually profitable, defeating the all purpose. Please let me know what you think about that and also if I'm using the add on somewhat incorrectly. |
|
Hm so with one click you want to queue all recipes with the concentration based optimizations like above I kinda get what you want. Actually.. I think this "conflict of design opinions" screams for us to start the implementation on "craft lists". |
|
I see the point now @derfloh205. I didn't think about the fact that a recipe could be profitable with or without concentration. The thing is that I actually can't queue, even with multiple clicks, the recipes that requires zero concentration and are profitable. What I usually do is:
Maybe there is a better way to approach that? Taking into consideration that the smart queuing is about optimizing concentrations usage per profit and given my current workflow, however, what I think would be nice is:
In my opinion, I would also apply the quantity offset only to the zero concentration recipes since that's the only case in which I can really decide how many recipe I want to craft, the others are already limited by the concentration that I have. One more thing is that I find a bit confusing that without smart concentration enabled the system will also queue non-profitable recipes, while with smart concentration it only queues the profitable ones. But that's might be a skill issue on my side. 😅 The craft list idea is really interesting! How would that intersect with the crafting window and the scan profession one? |


Summary
Zero Concentration Queueingoption to Queue Favorites settings.Smart Concentration Queueingis enabled, this option also queues favorite recipe result types that require zero concentration only if profitable.Description
What changed
Zero Concentration QueueingBehavior details
Smart Concentration Queueing = OFF:Smart Concentration Queueing = ONandZero Concentration Queueing = OFF:Smart Concentration Queueing = ONandZero Concentration Queueing = ON:Notes