Use correct icon for historic=castle && ruins=yes#243
Open
marcows wants to merge 1 commit intoder-stefan:masterfrom
Open
Use correct icon for historic=castle && ruins=yes#243marcows wants to merge 1 commit intoder-stefan:masterfrom
marcows wants to merge 1 commit intoder-stefan:masterfrom
Conversation
castle.png was used instead of castle_ruins.png The existing rule further down wasn't used for this tagging because it already matched with the first castle-only rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested this patch, but guess it works as expected. I simply adapted
the rules to how it is done in the 'tower' vs. 'observation_tower' case.
Became aware of this wrong rendering by this OSM note:
https://www.openstreetmap.org/note/2152613