Skip to content

fix: fix make_pod static asserts #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix make_pod static asserts #1312

wants to merge 2 commits into from

Conversation

CGQAQ
Copy link

@CGQAQ CGQAQ commented Sep 7, 2023 •
edited
Loading

  • std::is_pod is deprecated in c++20 changed to std::is_standard_layout && std::is_trivial
  • V shoud be trivially_copyable in order to copy from

@CGQAQ
fix: fix make_pod static asserts
d1b32da 
* std::is_pod is deprecated in c++20 changed
to std::is_standard_layout && is_trivial
* V shoud be trivially_copyable in order to
copy from
@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CGQAQ
Copy link
Author

CGQAQ commented Sep 8, 2023 •
edited
Loading

Seems like we are memcpying std::shared_ptr in the test, which is not safe I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGQAQ @CLAassistant