feat(desktop): autodetect React Router framework#35557
Open
akazwz wants to merge 2 commits into
Open
Conversation
Deno Individual Contributor License AgreementAll contributors have signed the CLA. Thank you! This is an automated message from CLA Assistant |
8ee4f35 to
9162d2b
Compare
Member
|
@akazwz thanks for the PR; could you get CI to pass? |
Author
|
Thanks for the heads up! I updated the framework detection golden output, and CI is green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@react-router/devbefore falling through to generic Vite detectionbuild/cliententrypoint for React Router SPA mode (ssr: false) with an HTML fallbackbuild/clientassets first, then routes requests through React Router'screateRequestHandlerdeno compile .anddeno desktop .supported framework messagesDocs PR: denoland/docs#3361
Notes
React Router's default server entry uses Node's
renderToPipeableStream; projects building with Deno need to provide a Web Streams-compatibleapp/entry.server.tsxusingrenderToReadableStream. The generated runtime entrypoint assumes the project has already built successfully with Deno.Testing
cargo fmt --checkgit diff --checkcargo test -p deno react_router --lib -- --nocapture(fails before running tests in this local checkout because clang rejects the configured-fuse-ld=lldlinker flag)deno task buildin a React Router SPA sampleapp/entry.server.tsx, plus manual handler/static-asset smoke checks