Skip to content

Security Fixes#31

Merged
chronarchitect merged 4 commits into
mainfrom
usr/mangirish/sq_changes
Jun 23, 2026
Merged

Security Fixes#31
chronarchitect merged 4 commits into
mainfrom
usr/mangirish/sq_changes

Conversation

@chronarchitect

@chronarchitect chronarchitect commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes lint, sanity, sonarr, blackduck, and checkmarx issues.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

MangirishK and others added 3 commits June 23, 2026 06:12
@MangirishK
SQ Fixes
4d1107a
@chronarchitect @devin-ai-integration
Deduplicate vdc_certificate and vdc_certificate_chain modules
876975e 
Extract shared helpers (ensure_client_stub_compatibility, read_pem_param,
get_chain_metadata, connect_keystore, fetch_current_chain, apply_certificate,
verify_and_get_details) into a new vdc_cert_common.py module_utils file.

Both modules now import from the shared file and differ only in their
DOCUMENTATION blocks and three configuration constants (_LABEL,
_DETAILS_KEY, and the keystore API class). This eliminates ~87%
code duplication flagged by SonarQube.

All 267 existing unit tests pass (133 vdc_certificate/chain + 92
info + 42 keystore API).

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@chronarchitect @devin-ai-integration
Fix bucket creation: pass namespace as x-emc-namespace header, add vp…
085010e 
…ool support

The ObjectScale management API requires the namespace to be passed as
the x-emc-namespace HTTP header rather than in the JSON body. The
generated client only puts it in the body, which causes a 500 Server
Error on some ObjectScale versions.

Also adds an optional vpool parameter to the bucket module so the
replication group can be specified during bucket creation.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@chronarchitect chronarchitect merged commit 38e7368 into main Jun 23, 2026
44 of 48 checks passed
@chronarchitect chronarchitect deleted the usr/mangirish/sq_changes branch June 23, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShrinidhiRao15 ShrinidhiRao15 ShrinidhiRao15 approved these changes
@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes
@rounak-adhikary rounak-adhikary Awaiting requested review from rounak-adhikary rounak-adhikary is a code owner
@MangirishK MangirishK Awaiting requested review from MangirishK MangirishK is a code owner
@Saksham-Nautiyal Saksham-Nautiyal Awaiting requested review from Saksham-Nautiyal Saksham-Nautiyal is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chronarchitect @ShrinidhiRao15 @Krunal-Thakkar @MangirishK