Conversation
Type sort labels a card with every one of its card types, so Legendary Artifact Creatures show up in three buckets and the group headers add up to more than the cube's card count -- users routinely misread this as a bug. Add a Type (Primary) variant that reuses Type's ranked label list (CARD_TYPES priority order followed by custom types alphabetical) but returns only the card's first-matching bucket, so every card lands in exactly one group and the buckets sum to the cube total. Contraption and Plane keep their existing single-label overrides.
📊 Server Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tired of the repeated question of why "Type" causes duplicates, so this is just a stab at a possible way to make a more logical Type sort by defining an opinionated order of types and ensuring that each card only falls into the first one it matches.
I'm using the existing type display order here, but that's possibly questionable because Land gets put near the end of that which might be more confusing to people that expect their
Ancient DenorDryad Arborto show up under Lands..If there's a desire to rank Lands higher, but still display them last, then it might be best to create a secondary ordinal list - one for display and one for sort.