Conversation
📊 Server Code Coverage Report
|
Stamp per-board name-grouped copy counts on cards in CubeContext before the filter runs so quantity/count/copies>=N and is:singleton/not:singleton can filter within a board (matches Collapse Duplicates). Outside a cube list every card reads as one copy, so quantity>1 returns nothing and is:singleton matches everything. Fixes the isOpValue grammar wrapper to forward the card argument so detectors that need it (voucher, finish variants, new singleton) receive it.
haganbmj
force-pushed
the
filter-quantity
branch
from
September 10, 2026 01:40
606bdfa to
d8d98f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-board name-grouped copy counts are stamped on cards in
CubeContextbefore the filter runs. Addsquantity:,count:,copies:numeric filters plusis:singleton/not:singletoncategory aliases. Scoped per board to match Collapse Duplicates.Outside a cube list every card reads as one copy, so
quantity>1returns nothing andis:singletonmatches everything (documented in the wiki entry).Also fixes the
isOpValuegrammar wrapper that was silently dropping thecardargument, so category detectors that need the card object (is:voucher,is:foil/nonfoil/etched/altfoil, and the newsingleton) now actually receive it.EDIT: Removed the generated nearley file because it looks to be out of sync with master.
EDIT2: Bleh.. that causes the tests to fail.
EDIT3: Fixed.