fix html_regexp leak#4
Open
liweinan wants to merge 1 commit into
Open
Conversation
midu
referenced
this pull request
in challengepost/acts_as_sanitiled
Apr 24, 2012
Little tweak to make it work with Rails 3.0.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acts_as_textiled is currently vulnerable to improperly closed quotes html tag. Here is an example:
If user input the above messages to website that is using acts_as_textiled, and if the website wants to show the message in :plain format, then ruby will hit CPU usage to 100% and blocks the http thread. And the http server goes down.
The cause is because of the regexp used in lib/acts_as_textiled.rb:
It cannot deal with the dirty quotes in html properly. I've tested it on:
And here is the code to reproduce the problem: