Edit GUI spine scenes using editor scripts #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore CI failures, it works — it's editor only changes :D |
matgis
requested changes
Jun 9, 2025
| gui/GuiSceneNode :spine-scenes | ||
| :add {SpineSceneNode (partial g/expand-ec attach-spine-scene-to-gui-scene)} | ||
| :get (fn get-spine-scenes [gui-scene-node {:keys [basis] :as evaluation-context}] | ||
| (attachment/nodes-getter (gui-scene-node->spine-scenes-node basis gui-scene-node) evaluation-context))) |
There was a problem hiding this comment.
This registration will leak state to subsequent editor tests. I think we should store this state in the workspace similar to how we do with resource-types. We also have a similar issue with gui/register-node-type-info! that we have hacks in the tests for. Let's that this opportunity to address both issues!
| (g/connect spine-scene :build-errors spine-scenes-node :build-errors) | ||
| (g/connect spine-scene :node-outline spine-scenes-node :child-outlines) | ||
| (g/connect spine-scene :name spine-scenes-node :names) | ||
| (g/connect spine-scenes-node :name-counts spine-scene :name-counts))) |
There was a problem hiding this comment.
Indentation is messed up. Do you need to add the extension-spine repo as a :source-path? I posted in the Slack about this a few days ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on defold/defold#10812