-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fix: Update Agent's docstrings #10071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ai/haystack into update-agent-docstrings
| last_message_only: false | ||
| connections: | ||
| - sender: DeepsetChatHistoryParser.messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agnieszka-m we shouldn't be using custom components that are not available in haystack in our examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I get it but the point of this example is for the platform users to be able to use it and the easiest way to feed the query to the agent is with this custom component, that's also the recommended way so I'd rather not complicate things with an outputadapter or something.
I think ultimately we'll want to filter these examples by product, so haystack users would only see python and platform users would only see yaml. That's the ideal state after rebranding. Until then, we'll have to deal with it somehow.
Do you think it's OK to leave it like that or do you have other ideas? @sjrl
|
@agnieszka-m I'm also wondering if there is a way we could make the yaml part a more complete example. For example, this requires the core integration |
Pull Request Test Coverage Report for Build 19327416769Details
💛 - Coveralls |
|
@sjrl to be honest, I just created an example that makes sense for the platform. I don't know much about haystack and what's needed to make it work there so if we want an example that works in haystack, I'd rely on someone from the haystack team to provide it. I'd like this one to stay as is because it's shown in the Builder through docstrings as the component docs. I can add some lead-in sentence that this makes sense in the platform or something? not sure how to solve it for now. I guess the problem will be gone once we can build the docs with conditional filters by product. |
Related Issues
Proposed Changes:
Updated Agent's docstrings as per Eliza's and Malte's suggestions to make the messaging consistent across communication channels.
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.