-
Notifications
You must be signed in to change notification settings - Fork 168
feat: Add Secret support to MCPTool and MCPToolset #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@davidsbatista I think it makes more sense to ask @Amnah199 for a review as she is much more familiar with this code and will maintain it with me. But please by all means have a look as well. |
Tested with itinerary agent, which uses mcp heavily, e2e for ay potential issues - none found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @davidsbatista , @Amnah199 could you please prfioritize review of this one :-) |
@Amnah199 could you please also take a quick look? |
integrations/mcp/src/haystack_integrations/tools/mcp/mcp_tool.py
Outdated
Show resolved
Hide resolved
integrations/mcp/src/haystack_integrations/tools/mcp/mcp_tool.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few comments
Co-authored-by: Amna Mubashar <[email protected]>
Co-authored-by: Amna Mubashar <[email protected]>
Spot on @Amnah199 - much simpler now - please have another look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. LGTM!
Why:
Fixed a security vulnerability where sensitive data (API keys, tokens, environment variables) in MCP server configurations were being serialized as plain text instead of using Haystack's Secret class for proper protection.
What:
How can it be used:
Recommended approach (with Secrets):
Backward-compatible approach (plain strings):
How did you test it:
Notes for the reviewer: