-
Notifications
You must be signed in to change notification settings - Fork 184
Update README.md #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #750
Conversation
Merge devel into master
It seems 'pert_box' dose not work as percentage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Though, I do think pert_box
serves as changing the percentage, instead of an absolute length for box length. (See
def gen_random_emat(etmax, diag=0): |
Right. I misunderstood, only saw emat = emat + np.eye(3) and not I originally had a interest this part, because some of my POSCARs generated by init_bulk has highly deformed cell. Thanks. |
I see what you mean, maybe "ratio" is more appropriate than "percentage" |
I close this PR as the README has been fully refactored. If one wants to change the documentation, go to |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## devel #750 +/- ##
==========================================
- Coverage 33.94% 33.91% -0.03%
==========================================
Files 86 93 +7
Lines 15424 16562 +1138
==========================================
+ Hits 5235 5617 +382
- Misses 10189 10945 +756 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
'pert_box' dose not seems to work as percentage.