Constants as openapi const union type#1095
Closed
apasquini95 wants to merge 9 commits intodedoc:mainfrom
Closed
Conversation
…asquini95/scramble into constants-as-openapi-const-union-type
Member
|
@apasquini95 thanks for the pr, but this is not something I want to be a default behavior. If you need this for your projects, consider using a document transformer and manually patch schemas there (there is an open api object traverser that can be handy for this task). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone, I'm opening this PR as an enhancement of the previous one (#1086). I introduced the
constschema also when handling union types, but only if the literal has only one value.Union type with single literal value:
Union type with more than one literal value:
I decided to leave the
enumschema when there are more than one literal of the same type just to avoid having a much longer result and keep its readability.