bugfix(#53): improve hierarchy handling in ImportService and add deta… - #54
Merged
dgraf-gh merged 1 commit intoAug 5, 2026
Conversation
…iled admin level validation tests - Updated `isAdministrativeBoundary` to handle additional relation types (`multipolygon`, `multilinestring`, `route`) and improve admin level checks. - Enhanced `ImportServiceTest` with new test cases for boundary hierarchy validation and admin level 2 inclusion. - Added logging to `HierarchyCache` for better error reporting during boundary and grid candidate fetch operations. - Refactored POI search logic for efficiency and reduced redundant checks in tests.
dgraf-gh
deleted the
53-missing-admin_level2-boundaries-for-some-countries-us-france-no-country_code-returned
branch
August 5, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iled admin level validation tests
isAdministrativeBoundaryto handle additional relation types (multipolygon,multilinestring,route) and improve admin level checks.ImportServiceTestwith new test cases for boundary hierarchy validation and admin level 2 inclusion.HierarchyCachefor better error reporting during boundary and grid candidate fetch operations.