feat(auth): bind loopback callback lifetime - #90
Open
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Open
feat(auth): bind loopback callback lifetime#90Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Windsor Nguyễn (windsornguyen) wants to merge 1 commit into
Conversation
Signed-off-by: Windsor Nguyen <93564933+windsornguyen@users.noreply.github.com>
Windsor Nguyễn (windsornguyen)
requested review from
AgentWings and
annyzhou
September 11, 2026 19:33
Windsor Nguyễn (windsornguyen)
added this pull request to stack #57
September 11, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Authorship: AI-assisted.
Summary
Bind browser authorization to one loopback listener with verified state and issuer.
Public CLI activation follows in a later layer. Hosted authentication requires a compatible server deployment.
Changes
src/auth/README.mdsrc/auth/oauth/callback.tssrc/auth/oauth/loopback.tssrc/auth/oauth/page.tstests/auth/callback-listener.test.tsVerification
Verified at
c4c362787e773ce61f7106a643c8f14601895464against its immediate parent.Scope
Human-written additions + deletions: 378.
Depends on #89. Retains #60: valid automatic retry keys.
The layer keeps its boundary implementation and direct contract tests together. Command activation and unrelated integrations remain separate.
Review focus
Credential rejection must stop its selected path. Keep token persistence, revocation, safe output, and caller identity consistent with the tested contract.
Documentation
Authentication contract at this head.
Reviewers