Skip to content

Match ugen/aio and ugen/reg_mgr#55

Merged
LLONSIT merged 14 commits intodecompals:mainfrom
LLONSIT:main
Mar 3, 2026
Merged

Match ugen/aio and ugen/reg_mgr#55
LLONSIT merged 14 commits intodecompals:mainfrom
LLONSIT:main

Conversation

@LLONSIT
Copy link
Collaborator

@LLONSIT LLONSIT commented Feb 26, 2026

  • Match aio.p and reg_mgr.p thanks to @Synray
  • Match some functions in cfe/codegen
  • Document cat_files in ugen/binfile
  • Document some parts of libu/ucio

Copy link
Collaborator

@Unnunu Unnunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I have a few comments, mostly about replacing numeric constants with the corresponding enum members.

int sp20;

sp20 = arg0;
UWRITE(&sp20, 8U);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This writes 8 bytes from the stack, which makes the code non-portable. It should be a single long long int, e.g. long long int sp20 = arg0;

Copy link
Collaborator Author

@LLONSIT LLONSIT Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a single long long int, e.g. long long int sp20 = arg0;

Well, this is the only match i found using a long long

void UW_CONST_i(int arg0) {
    union {
        long long l;
        int i;
    } sp20;

    sp20.i = arg0;
    UWRITE(&sp20, sizeof(sp20.l));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s fine

LLONSIT and others added 9 commits February 27, 2026 11:16
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
@LLONSIT LLONSIT changed the title Match almost all functions in ugen/aio Match ugen/aio and ugen/reg_mgr Feb 27, 2026
@LLONSIT
Copy link
Collaborator Author

LLONSIT commented Mar 2, 2026

Forgot to mention this in the commit messages, but i borrow the Uw_ types from this scratch made by @EllipticEllipsis

https://decomp.me/scratch/zvPvV

@LLONSIT LLONSIT merged commit c8a4871 into decompals:main Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants