Match ugen/aio and ugen/reg_mgr#55
Merged
LLONSIT merged 14 commits intodecompals:mainfrom Mar 3, 2026
Merged
Conversation
Unnunu
requested changes
Feb 27, 2026
Collaborator
Unnunu
left a comment
There was a problem hiding this comment.
Great work. I have a few comments, mostly about replacing numeric constants with the corresponding enum members.
src/cfe/codegen.c
Outdated
| int sp20; | ||
|
|
||
| sp20 = arg0; | ||
| UWRITE(&sp20, 8U); |
Collaborator
There was a problem hiding this comment.
This writes 8 bytes from the stack, which makes the code non-portable. It should be a single long long int, e.g. long long int sp20 = arg0;
Collaborator
Author
There was a problem hiding this comment.
It should be a single long long int, e.g. long long int sp20 = arg0;
Well, this is the only match i found using a long long
void UW_CONST_i(int arg0) {
union {
long long l;
int i;
} sp20;
sp20.i = arg0;
UWRITE(&sp20, sizeof(sp20.l));
}Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Co-authored-by: Unnunu <serge_zorkin@mail.ru>
Collaborator
Author
|
Forgot to mention this in the commit messages, but i borrow the |
Unnunu
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cat_filesin ugen/binfile