fix(module): will not deploy virtualization if moduleconfig is not valid #1134
+186
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavborbat
force-pushed
the
fix/module/do-not-deploy-if-moduleconfig-is-not-valid
branch
from
5fcd475 to
b083539
Compare
yaroslavborbat
changed the title
yaroslavborbat
requested review from
fl64,
z9r5,
goganat and
Isteb4k
as code owners
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat
force-pushed
the
fix/module/do-not-deploy-if-moduleconfig-is-not-valid
branch
from
b083539 to
57cee7f
Compare
z9r5
approved these changes
Jun 11, 2025
diafour
reviewed
Jun 19, 2025
| except ValueError as e: | ||
| print(f"ERROR: {e}") | ||
|
|
||
| self.set_value(self.path, ctx.values, False) |
There was a problem hiding this comment.
Will it ends up here if there are no "cidrs" in ModuleConfig?
It seems there should be another check to set isReady=False if "cidrs" are empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set isReady flag if required fields in ModuleConfig are valid (i.e. cidrs).
Why do we need it, and what problem does it solve?
User should be able to enable virtualization module with empty settings in ModuleConfig.
There are no mechanics in deckhouse to prevent module enablement with empty settings, so we use a workaround: do not deploy module resources if ModuleConfig is not valid.
What is the expected result?
Checklist
Changelog entries