-
Notifications
You must be signed in to change notification settings - Fork 2
feat(module): detect nodes with enabled /dev/kvm to schedule virt-handlers #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b120987
to
8ddb674
Compare
z9r5
previously approved these changes
May 22, 2025
8ddb674
to
2e21918
Compare
4 tasks
4c7965a
to
4c6ca06
Compare
eb277da
to
ba96910
Compare
Signed-off-by: Pavel Tishkov <[email protected]>
a3bd209
to
1ff1e78
Compare
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
Signed-off-by: Pavel Tishkov <[email protected]>
d91908e
to
31c0d3a
Compare
Signed-off-by: Pavel Tishkov <[email protected]>
31c0d3a
to
fa2fddd
Compare
Signed-off-by: Pavel Tishkov <[email protected]>
yaroslavborbat
requested changes
Jun 17, 2025
Signed-off-by: Pavel Tishkov <[email protected]>
yaroslavborbat
approved these changes
Jun 19, 2025
This was referenced Jun 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detect nodes with enabled /dev/kvm and CPU features VMX/SVM to schedule virt-handlers only on capable nodes.
Why do we need it, and what problem does it solve?
The virtualization module for creating VMs requires the presence of /dev/kvm and CPU features such as VMX (Intel) or SVM (AMD). However, in hybrid clusters, some nodes may lack these capabilities, causing virt-handler pods to fail during startup.
What is the expected result?
This change ensures that virt-handler pods are scheduled only onto nodes that have both the required device (/dev/kvm) and CPU features (VMX/SVM), preventing scheduling failures and improving stability in heterogeneous environments.
Checklist
Changelog entries