added technical question about protocols requirement and additional properties clarification . #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@andorsk to re-review |
TallTed
suggested changes
Mar 20, 2024
Contributor
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
Small, for humans (including author)
| - **What's the point of the protocols property in the protocols specification? | ||
| Why does it need to exist?** It is the URI which items are bucketed under. You | ||
| create records under that uri namespace. Protocol and schema are required to be URIs | ||
| - **No additional properties?** Becausae JSON Schema |
Contributor
There was a problem hiding this comment.
Suggested change
| - **No additional properties?** Becausae JSON Schema | |
| - **No additional properties?** Because JSON Schema ??? |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.