[skill] Kafka version upgrade skill - #2476
Open
jpechane wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jiri Pechanec <jiri.pechanec@centrum.cz>
Naros
reviewed
Aug 21, 2026
Comment on lines
+34
to
+35
| cd /home/jpechane/sources/debezium/debezium && git checkout -b "dbz#<ISSUE_NO>" | ||
| cd /home/jpechane/sources/debezium/container-images && git checkout -b "dbz#<ISSUE_NO>" |
Member
There was a problem hiding this comment.
These include your local paths, so I wonder whether the agent should clone the specific repositories into /tmp instead? There are several other occurrences of this below.
Contributor
Author
There was a problem hiding this comment.
This is a good point and I've hit it for other skill as well. Still I'dont like the idea of global /tmp.
How about defining some global directory patern in home like $HOME/skill-data/<skill-name> that would be used universally by all skills or maybe the agent should ask for the user input if the locations of the directories is not known?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.