Add clear cache button and automatically clear on version bump#627
Conversation
ElliottKasoar
left a comment
There was a problem hiding this comment.
Nice!
What's the benefit of client-side callbacks vs some sort of pattern-matching explicit clear as a Python callback?
I also think there may be a bug in the storage, since the weights etc. don't seem to be persisted once I close the tab. I'm not sure that's introduced here, but it makes it harder to test the version clear since I think it happens anyway.
I'd probably also make the button more prominent, perhaps next to the tutorial button? It's quite out of the way currently.
3b2531b to
5a9b616
Compare
|
ElliottKasoar
left a comment
There was a problem hiding this comment.
Similarly to #699, I think ideally this wouldn't live in ml_peg/app/build_app.py, but otherwise this is nice, thanks!
1c4f606 to
2eb1014
Compare
ElliottKasoar
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Linked issue
Resolves #
Testing