Conversation
* We don't really suggest the `drupal` project type any more. It was too complicated for people. Still supported but not mentioned. Using `drupal11` here. * There's no need these days to add `--php-version=8.3 --corepack-enable`. Default PHP version is 8.4 (as per drupal11 support) and `corepack-enable` is automatic for drupal11. However, if you think the default version of PHP (8.4) is not a good idea, this could be shown as `--php-version=8.4` to show people explicitly how to change it.
Member
Author
|
One minor note: When testing this, I was unable to add drush/drush; the dependency problems baffled me. I would have expected drush to already be provided in this add-on's composer.json goodies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
drupalproject type any more. It was too complicated for people. Still supported but not mentioned. Usingdrupal11here.--php-version=8.3 --corepack-enable. Default PHP version is 8.4 (as per drupal11 support) andcorepack-enableis automatic for drupal11. However, if you think the default version of PHP (8.4) is not a good idea, this could be shown as--php-version=8.4to show people explicitly how to change it.How This PR Solves The Issue
Minor README updates