clean-up of the card layout #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
buseca
commented
Dec 9, 2023
buseca
commented
- component cardDescription removed because not used
- cardHeader removed, not needed
- 'title' renamed 'columnName'
- margin of tags fixed
- component cardDescription removed because not used - cardHeader removed, not needed - 'title' renamed 'columnName' - margin of tags fixed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
|
@dbertella check the clean up i did, it seems cardDescription was obsolete, and cardHeader was a useless container. But there is still an issue: |
dbertella
reviewed
Dec 10, 2023
the <h3> in the card is not rendered if empty
Collaborator
Author
|
@dbertella now it doesn't render the inside the card if it has no title.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.