Skip to content

Fix GNSS data retrieval and downloading functions#794

Open
sssangha wants to merge 3 commits intodevfrom
unr_archive_migration
Open

Fix GNSS data retrieval and downloading functions#794
sssangha wants to merge 3 commits intodevfrom
unr_archive_migration

Conversation

@sssangha
Copy link
Copy Markdown
Collaborator

@sssangha sssangha commented Apr 8, 2026

Updated the get_stats_by_llh function to prioritize IGS20 coordinates over legacy data.

Enhanced the download_UNR function to include a fallback to the legacy archive when downloading tropospheric delays.

Context: There appears to be ongoing migration of data in the UNR archive such that data from much of the eastern hemisphere is disrupted after 2023. This PR is intended to circumvent this.

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

sssangha added 3 commits April 8, 2026 15:29
Updated the get_stats_by_llh function to prioritize IGS20 coordinates over legacy data.

Enhanced the download_UNR function to include a fallback to the legacy archive when downloading tropospheric delays.

Context: There appears to be ongoing migration of data in the UNR archive such that data from much of the eastern hemisphere is disrupted after 2023. This PR is intended to circumvent this.
Added entry for PR #794 to address data migration issues in the UNR archive affecting the eastern hemisphere.
@sssangha sssangha marked this pull request as ready for review April 15, 2026 00:30
Copy link
Copy Markdown
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sssangha just a couple comments about workflow.

url_igs20 = f'{baseURL}gps_timeseries/IGS20/llh/llh.out'
col_names = ['ID', 'Lat', 'Lon', 'Hgt_m']

# Read legacy list
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sssangha would it make more sense to wrap all of the legacy calls within a single try/except that checks for stations for which IGS20 was successful for all stations and then pulls legacy data only for the subset of stations that are not available? That way the IGS20 is still the default and all the work needed if legacy stations are required is skipped unless they are actually needed.

# Try IGS20 first
filepath = download_url(url_igs20, save_loc)

# If IGS20 is missing, try legacy
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if a subset of stations is available but others are not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants