Dev

[dbarzin]

Summary by CodeRabbit

• Refactor

  • Simplified internal relationship naming conventions for improved code consistency.

• Bug Fixes

  • Enhanced IP address validation with null-safety checks.

• Chores

  • Optimized build process to skip unnecessary commits when assets remain unchanged.

[coderabbitai]

Walkthrough

Building model relationship methods renamed from verbose internal names to simplified aliases. BuildingController updated to use the new method names. Subnetwork::contains now accepts nullable strings with a guard clause. Build script conditional logic prevents unnecessary git operations when no asset changes detected.

Changes

Cohort / File(s)	Summary
Building Model Relationship Renames app/Models/Building.php	Renamed seven public relationship methods to simplified names: buildingPhysicalServers → physicalServers, buildingWorkstations → workstations, buildingStorageDevices → storageDevices, buildingPeripherals → peripherals, buildingPhones → phones, wifiTerminals → terminals, buildingPhysicalSwitches → physicalSwitches. All maintain identical Eloquent configuration and ordering.
Controller Update app/Http/Controllers/Admin/BuildingController.php	Updated Building@show method to eager-load relations using new simplified relationship names instead of verbose internal names. No control flow changes.
Subnetwork Null Safety app/Models/Subnetwork.php	Modified contains() method signature from contains(string $ip): bool to contains(?string $ip): bool and added guard clause returning false when input is null.
Build Script Conditional build.sh	Replaced unconditional git push sequence with conditional that only executes add/commit/push when changes exist in public/build/assets/. Prints message and continues if no changes detected.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Relationship renames follow a consistent pattern across the model; verify all usages are updated in controller and elsewhere
• Subnetwork::contains null-safety change: confirm null handling doesn't introduce unintended behavior in calling code
• Build script conditional: verify asset change detection logic is reliable and doesn't mask legitimate build failures

Poem

🐰 Relations renamed, now they're lean and clean,
No "building" prefix clutters the scene!
Null checks stand guard at Subnetwork's door,
Build script's more thoughtful than e'er before!
Cleaner code hops along—what a delight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Dev' is vague and generic, providing no meaningful information about the changeset's actual purpose or scope.	Replace with a descriptive title summarizing the main changes, such as 'Rename Building model relations and update Subnetwork::contains signature' or 'Refactor relation names and improve null handling'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 90.91% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/Models/Building.php (1)

70-73: Remove duplicate relationship method buildingPhysicalSwitch().

This method is a duplicate of physicalSwitches() at line 106. Both define identical HasMany relationships to PhysicalSwitch with the same foreign key, local key, and ordering. Keeping both methods creates ambiguity and can lead to confusion about which one should be used.

Apply this diff to remove the duplicate:

-    /** @return HasMany<PhysicalSwitch, $this> */
-    public function buildingPhysicalSwitch(): HasMany
-    {
-        return $this->hasMany(PhysicalSwitch::class, 'building_id', 'id')->orderBy('name');
-    }
-

🧹 Nitpick comments (1)

app/Models/Subnetwork.php (1)

214-218: Add braces to the if statement for consistency with coding standards.

While PHP allows single-line if statements without braces, PSR-2 coding standards recommend always using braces for control structures to improve readability and prevent future bugs.

Apply this diff:

     public function contains(?string $ip): bool
     {
-        if ($ip === null)
+        if ($ip === null) {
             return false;
+        }
         
         $cidr = $this->address;

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 2bd6dc3 and a972f91.

📒 Files selected for processing (4)

• app/Http/Controllers/Admin/BuildingController.php (1 hunks)
• app/Models/Building.php (2 hunks)
• app/Models/Subnetwork.php (1 hunks)
• build.sh (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

build.sh (1)

34-41: LGTM! Good improvement to prevent unnecessary commits.

The conditional logic correctly prevents git operations when there are no changes in public/build/assets/, avoiding empty commits.

app/Http/Controllers/Admin/BuildingController.php (1)

141-141: LGTM! Relationship names are consistent with the Building model.

The eager-loaded relationships correctly reference the renamed methods in the Building model.

app/Models/Building.php (1)

58-61: LGTM! Relationship method names simplified effectively.

The renamed relationship methods maintain correct HasMany configurations with proper foreign keys, local keys, and ordering. The new names are cleaner and more consistent.

Also applies to: 76-79, 82-85, 88-91, 94-97, 100-103, 106-109