Skip to content

Conversation

@Tpuljak
Copy link
Member

@Tpuljak Tpuljak commented Nov 13, 2025

Description

Add dockerfile to dashboard for separate deployment.

Documentation

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

@Tpuljak Tpuljak force-pushed the dashboard-dockerfile branch from c27867b to 880b62d Compare November 13, 2025 10:25
@Tpuljak Tpuljak requested a review from Copilot November 13, 2025 10:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces separate deployment capability for the dashboard by creating a standalone Docker container. The API service can now optionally disable serving dashboard static files via a new environment variable, allowing the dashboard to be deployed independently using nginx.

Key changes:

  • Added Dockerfile and nginx configuration for standalone dashboard deployment
  • Introduced DONT_SERVE_DASHBOARD environment variable to control whether API serves dashboard files
  • Updated API module to conditionally serve static dashboard files based on configuration

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/dashboard/Dockerfile New multi-stage Dockerfile for building and serving dashboard with nginx
apps/dashboard/docker/nginx/default.conf nginx configuration for serving dashboard with routing to /dashboard path
apps/dashboard/docker/entrypoint.sh Entrypoint script to inject API URL and start nginx
apps/dashboard/project.json Added docker build and version check tasks
apps/api/src/app.module.ts Modified ServeStaticModule to conditionally serve dashboard based on configuration
apps/api/src/config/configuration.ts Added dontServeDashboard configuration property
apps/api/Dockerfile Set default value for DONT_SERVE_DASHBOARD environment variable
apps/api/.env Added DONT_SERVE_DASHBOARD environment variable for local development
apps/api/src/main.ts Removed await from otelSdk.start() call
apps/docs/src/content/docs/en/oss-deployment.mdx Documented new DONT_SERVE_DASHBOARD environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tpuljak Tpuljak requested review from gdraganic and zzorica November 13, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants