Allow override of AR and OUTDIR #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change assignment operator of OUTDIR to ?= and add AR, defaulting to `ar`
Allow override of AR and OUTDIR
|
The assignment of OUTDIR using "::=" is intentional, you can still override its value on the command line and that is what is intended ( The AR change is fine. Your PR contains a merge commit that shouldn't be present. Looks like you opened a PR in your own fork, merged that to your fork's master branch, and then opened a PR from your fork's master to this repo. You should open the PR from the original branch that you made the change on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change assignment operator of OUTDIR to ?= and add AR, defaulting to
ar